Fix a slight usability issue with TestFileIO #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew4699
requested review from
jbonofre,
ashvina,
RussellSpitzer,
snazy,
vvcephei,
takidau,
jackye1995,
flyrain,
eric-maynard,
collado-mike and
ebyhr
as code owners
eric-maynard
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TestFileIOs could be forced to throw an exception when calling getLength. Unfortunately this is hard to use because TestFileIOs also contain functionality for measuring file sizes. This meant that any supplied getLength exception would result in the construction of an InputFile to immediately fail instead of the exception being deferred to later.
This PR makes the TestFileIO use the non-exception-throwing-InputFile for measurement. Unfortunately the previous tests were relying on getLength being called at some point during the workloads but Iceberg seems to rarely call getLength, thus I just wrote a separate test to validate the functionality.
Type of change
How Has This Been Tested?
Checklist:
Please delete options that are not relevant.