Skip to content

Conversation

@sungwy
Copy link
Contributor

@sungwy sungwy commented Feb 6, 2026

This is a Draft PR I prepared to aid reviewing the new Authorization SPI Refactoring RFC

Checklist

  • πŸ›‘οΈ Don't disclose security issues! (contact security@apache.org)
  • πŸ”— Clearly explained why the changes are needed, or linked related issues: Fixes #
  • πŸ§ͺ Added/updated tests with good coverage, or manually tested (and explained how)
  • πŸ’‘ Added comments for complex logic
  • 🧾 Updated CHANGELOG.md (if needed)
  • πŸ“š Updated documentation in site/content/in-dev/unreleased (if needed)

op,
rootContainerWrapper,
null /* secondary */);
AuthorizationCallContext authzContext = new AuthorizationCallContext(resolutionManifest);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to inject it from CDI? Ideally resolutionManifest should also be a request-scoped (auto-created) bean, but for a start we could add it to AuthorizationCallContext manually since AuthorizationCallContext is expected to be mutable anyway πŸ€” WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dimas-b - great suggestion.

Yes, I think that aligns well with the proposed strategy to define the Resolution semantics at request-scope instead, and build consistency guarantees on it. I think creating a request-scoped bean for AuthorizationCallContext would be safe, and we can evaluate if we can do the same for the resolution semantics after a dedicated design proposal on the Resolution/Persistence model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants