Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup derby home dir #228

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Cleanup derby home dir #228

merged 2 commits into from
Sep 2, 2024

Conversation

MonkeyCanCode
Copy link
Contributor

@MonkeyCanCode MonkeyCanCode commented Aug 29, 2024

Description

This will cleanup derby home dir for regtest/setup.sh.

Fixes 217

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manually corrupted the derby home dir after a successful run. After derby home got corrupted, user won't be able to rerun the script until derby home is getting cleanup. With this fix, it will cleanup the derby home dir before running the script.

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue

Copy link
Contributor

@flyrain flyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MonkeyCanCode for the change.

@jbonofre jbonofre enabled auto-merge (squash) September 2, 2024 12:36
@jbonofre jbonofre merged commit 4b55a83 into apache:main Sep 2, 2024
3 checks passed
@MonkeyCanCode MonkeyCanCode deleted the 217 branch December 12, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The existing local derby directory fails the catalog creation
4 participants