Fix Pagination for Catalog Federation #1849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XJDKC
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
eric-maynard and
jackye1995
as code owners
XJDKC
requested review from
jbonofre,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain,
ebyhr,
ajantha-bhat and
HonahX
as code owners
|
@dimas-b pointed out that we could actually pass the pagination info down to the other catalog, which I agree with. But this change LGTM |
eric-maynard
previously approved these changes
Jun 10, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
dimas-b
reviewed
Jun 10, 2025
XJDKC
force-pushed
the
rxing-fix-pagination
branch
from
8c7437b to
9ba5d82
Compare
XJDKC
force-pushed
the
rxing-fix-pagination
branch
from
9ba5d82 to
1963ffb
Compare
eric-maynard
approved these changes
Jun 25, 2025
There was a problem hiding this comment.
Nice, thanks for adding tests! Let's wait for @dimas-b to have a look if possible.
dimas-b
approved these changes
Jun 25, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
flyrain
pushed a commit
that referenced
this pull request
Jul 2, 2025
Details can be found in this issue: #1848
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details can be found in this issue: #1848