Create LICENSE and NOTICE for "single" distribution #1694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update versions in the admin and server packages (docker image)
jbonofre
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
eric-maynard,
jackye1995,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain and
ebyhr
as code owners
jbonofre
requested review from
ajantha-bhat,
HonahX,
singhpk234 and
pingtimeout
as code owners
dimas-b
reviewed
May 28, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
adutra
reviewed
May 28, 2025
| // TODO: combine the LICENSE and NOTICE in a follow-up PR | ||
| from(adminDocs) | ||
| from("LICENSE") | ||
| from("NOTICE") |
There was a problem hiding this comment.
Do we still need the adminDocs configuration?
There was a problem hiding this comment.
My understanding was as "temp" workaround before handing LICENSE and NOTICE in the distribution. Let me double check.
There was a problem hiding this comment.
Agreed with @adutra! We could remove adminDocs in admin/build.gradle.kts.
eric-maynard
pushed a commit
to eric-maynard/polaris
that referenced
this pull request
May 28, 2025
Following up on apache#1694 * Restore `private` scope on internal fields in `IcebergCatalog` * Use a test-only setter instead of sub-classing to manage injecting test FileIO implementations
|
The PR LGTM with the minor comment here, #1694 (comment). BTW, do we have a tool to generate LICENSE and NOTICE automatically? |
flyrain
approved these changes
May 29, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates
LICENSEandNOTICEfor the single distribution and update version in server/admin packages.