feat(plc4j/modbus): ModbusOptimizer fixes for discrete-input and endianness #2055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Discrete Input handling when processing response
19 tasks
IsmoLeszczynski
changed the title
19 tasks
Fixed endianness resolution to check modbusTag overrides
|
Updated PR to include also a fix for #2058 |
IsmoLeszczynski
changed the title
16 tasks
|
LGTM, WDYT @chrisdutz? |
|
It does ... haven't had the chance to have a detailed look at it. But as I have never used the discrete-inputs anyway, I'll probably not get to doing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2054. Like the Coils, Discrete Inputs are also handled like single bits. The current implementation tried to handle them like Registers, which caused issues when the response consisted of a single byte instead of two. This solution merges the handling of Coils and Discrete Inputs as they're technically identical in this respect.
resolves #2054