Allow uploading realtime segments via CLI

[KKcorps]

Currently the method used only allows OFFLINE segments but we now support uploading segments to realtime tables.

#8584

[codecov-commenter]

Codecov Report

Merging #9861 (dff7f97) into master (e307106) will increase coverage by 42.39%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #9861       +/-   ##
=============================================
+ Coverage     28.06%   70.46%   +42.39%     
- Complexity       53     5062     +5009     
=============================================
  Files          1949     1982       +33     
  Lines        104632   106449     +1817     
  Branches      15847    16131      +284     
=============================================
+ Hits          29362    75004    +45642     
+ Misses        72395    26218    -46177     
- Partials       2875     5227     +2352     

Flag	Coverage Δ
integration1	25.09% <ø> (-0.13%)	⬇️
integration2	24.62% <ø> (+0.19%)	⬆️
unittests1	68.00% <ø> (?)
unittests2	15.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ery/aggregation/DoubleAggregationResultHolder.java	60.00% <0.00%> (-15.00%)	⬇️
.../tasks/BaseMultipleSegmentsConversionExecutor.java	82.35% <0.00%> (-7.51%)	⬇️
...tream/kafka20/server/KafkaDataServerStartable.java	72.91% <0.00%> (-6.25%)	⬇️
...apache/pinot/common/function/FunctionRegistry.java	81.63% <0.00%> (-5.21%)	⬇️
...transform/function/IsNotNullTransformFunction.java	65.51% <0.00%> (-3.45%)	⬇️
...g/apache/pinot/common/metrics/AbstractMetrics.java	80.83% <0.00%> (-2.50%)	⬇️
...nction/DistinctCountBitmapAggregationFunction.java	51.81% <0.00%> (-1.04%)	⬇️
...server/starter/helix/HelixInstanceDataManager.java	70.83% <0.00%> (-0.84%)	⬇️
...a/org/apache/pinot/core/operator/BaseOperator.java	100.00% <0.00%> (ø)
...a/org/apache/pinot/common/metrics/ServerMeter.java	100.00% <0.00%> (ø)
... and 1391 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[Jackie-Jiang]

This is backward incompatible change. Let's add a separate optional -type parameter, and make it default to OFFLINE

[KKcorps]

Done. but the reason I didn't want to make it backward compatible is this TODO comment in the existing /v2/segments code

    String rawTableName;
      if (StringUtils.isNotEmpty(tableName)) {
        rawTableName = TableNameBuilder.extractRawTableName(tableName);
      } else {
        // TODO: remove this when we completely deprecate the table name from segment metadata
        rawTableName = segmentMetadata.getTableName();
        LOGGER.warn("Table name is not provided as request query parameter when uploading segment: {} for table: {}",
            segmentName, rawTableName);
      }