[draft] Add chronicle bytes alternative to LArray.#9842
Closed
gortiz wants to merge 2 commits intoapache:masterfrom
Closed
[draft] Add chronicle bytes alternative to LArray.#9842gortiz wants to merge 2 commits intoapache:masterfrom
gortiz wants to merge 2 commits intoapache:masterfrom
Conversation
Still pending to add benchmarks and tests.
Contributor
Author
|
This first commit is a draft. Tests need to be extended to cover the new implementation and I would also add at least one benchmark to verify that there is no performance degradation. It would also be great to add some verification that with this change Pinot will be able to run with Java 17. Also, writing the code I've seen some places where the buffers are being use and there may be better implementations, but I would also need to benchmark the alternative to be sure (and this can be done in another PR) |
…ugs in chronicle bytes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR explores the possibility of using Chronicle Bytes as an implementation of PinotDataBuffer instead of LArray. The main reason to do that is to be able to run with newer JVM versions where LArray is not supported.
See #9162