Allow to configure multi-datadirs as instance configs and a Quickstart example about them#9705
Merged
npawar merged 3 commits intoapache:masterfrom Dec 7, 2022
Conversation
74f46ba to
120e673
Compare
Codecov Report
@@ Coverage Diff @@
## master #9705 +/- ##
============================================
- Coverage 70.46% 69.02% -1.44%
+ Complexity 5535 5064 -471
============================================
Files 1982 1982
Lines 106449 106496 +47
Branches 16131 16140 +9
============================================
- Hits 75006 73512 -1494
- Misses 26213 27833 +1620
+ Partials 5230 5151 -79
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
120e673 to
b3c3e4d
Compare
npawar
reviewed
Dec 6, 2022
pinot-tools/src/main/java/org/apache/pinot/tools/MultiDirQuickstart.java
Outdated
Show resolved
Hide resolved
pinot-tools/src/main/java/org/apache/pinot/tools/MultiDirQuickstart.java
Outdated
Show resolved
Hide resolved
...-tools/src/main/resources/examples/batch/airlineStats/airlineStats_offline_table_config.json
Outdated
Show resolved
Hide resolved
be2896d to
3bd6b06
Compare
npawar
approved these changes
Dec 7, 2022
Contributor
npawar
left a comment
There was a problem hiding this comment.
thanks for the config change. lgtm
3bd6b06 to
2ec5616
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the work to support multi-datadir for Pinot server as tracked by #8843.
This one makes it simpler and more consistent to configure the feature. And added a QuickStart example about how this works with the typical configs.
Release Note
One can config tier and its datadir as instance configs to be consistent across tables, e.g.
The
datadirfrom instance configs can be overwritten by tierConfigs in TableConfig, e.g.But the instance configs are more recommended to keep datadirs consistent across tables within a cluster.