[multistage] support like and regex like#9654
Merged
walterddr merged 2 commits intoapache:masterfrom Oct 25, 2022
Merged
Conversation
31 tasks
Jackie-Jiang
approved these changes
Oct 25, 2022
Codecov Report
@@ Coverage Diff @@
## master #9654 +/- ##
=============================================
- Coverage 68.63% 28.21% -40.42%
+ Complexity 4920 53 -4867
=============================================
Files 1947 1934 -13
Lines 104168 103808 -360
Branches 15796 15759 -37
=============================================
- Hits 71496 29290 -42206
- Misses 27556 71650 +44094
+ Partials 5116 2868 -2248
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support like and regex like
This prompts another v1 legacy issue, not all function evaluation has predicate/transform/scalar version - needs a clean up to make sure any function that can be evaluated at predicate time / transform time, should ALWAYS be usable at reduce/multistage.