add SegmentTierAssigner and refine restful APIs to get segment tier info#9598
Merged
npawar merged 3 commits intoapache:masterfrom Oct 18, 2022
Merged
add SegmentTierAssigner and refine restful APIs to get segment tier info#9598npawar merged 3 commits intoapache:masterfrom
npawar merged 3 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9598 +/- ##
=============================================
+ Coverage 25.84% 69.89% +44.04%
- Complexity 44 4977 +4933
=============================================
Files 1926 1939 +13
Lines 103305 103725 +420
Branches 15688 15739 +51
=============================================
+ Hits 26702 72497 +45795
+ Misses 73903 26119 -47784
- Partials 2700 5109 +2409
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1f252e0 to
57a1203
Compare
...ler/src/main/java/org/apache/pinot/controller/helix/core/relocation/SegmentTierAssigner.java
Outdated
Show resolved
Hide resolved
...ler/src/main/java/org/apache/pinot/controller/helix/core/relocation/SegmentTierAssigner.java
Outdated
Show resolved
Hide resolved
...ler/src/main/java/org/apache/pinot/controller/helix/core/relocation/SegmentTierAssigner.java
Outdated
Show resolved
Hide resolved
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
Outdated
Show resolved
Hide resolved
1a900e0 to
55a9458
Compare
npawar
reviewed
Oct 17, 2022
Contributor
npawar
left a comment
There was a problem hiding this comment.
please also add an example to the PR description, regarding the changes expected to the the API response
pinot-controller/src/main/java/org/apache/pinot/controller/util/TableTierReader.java
Outdated
Show resolved
Hide resolved
Jackie-Jiang
approved these changes
Oct 17, 2022
0b36a80 to
4824266
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the work to support multi-datadir for Pinot server as tracked by #8843.
Following up on #9306, this one adds the controller side periodic task SegmentTierAssigner to calculate the target tier for segment and set it in SegmentZKMetadata, as goal state to guide servers to put segments into the right datadir (i.e. tier).
The next PR will connect the two parts, i.e. reusing SegmentReloadMessage to notify servers to do the migration.
Release Note
New configs to turn on tier assigner:
Extended API to query segment tiers