Skip to content

[multistage] generated test for v2 engine#9452

Merged
siddharthteotia merged 3 commits intoapache:masterfrom
walterddr:pr_add_generated_itcase
Sep 27, 2022
Merged

[multistage] generated test for v2 engine#9452
siddharthteotia merged 3 commits intoapache:masterfrom
walterddr:pr_add_generated_itcase

Conversation

@walterddr
Copy link
Contributor

@walterddr walterddr commented Sep 23, 2022

main changelist

  • wrapped testQuery with a testQuery internal so that a wrapped error message will be surfaced.
  • skip comparison when brokerResponseRows is 0 row while h2query response is 1 row for aggregation only queries
    • this is due to difference in ways handling constant literal predicate (e.g. select SUM(a) from tbl WHER 1<>1 whether should return 0 rows or one row with zero as value.)
  • giving fuzzyCompare a larger error range

depends on:

@walterddr walterddr force-pushed the pr_add_generated_itcase branch from e080bbc to 699f594 Compare September 23, 2022 05:47
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022

Codecov Report

Merging #9452 (96dc535) into master (6e697d8) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9452      +/-   ##
============================================
- Coverage     69.87%   69.86%   -0.01%     
- Complexity     4819     4821       +2     
============================================
  Files          1910     1910              
  Lines        101769   101769              
  Branches      15444    15444              
============================================
- Hits          71109    71104       -5     
- Misses        25635    25649      +14     
+ Partials       5025     5016       -9     
Flag Coverage Δ
integration1 26.02% <ø> (+0.03%) ⬆️
integration2 24.76% <ø> (+0.10%) ⬆️
unittests1 67.12% <ø> (+<0.01%) ⬆️
unittests2 15.49% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntroller/helix/core/minion/TaskMetricsEmitter.java 34.88% <0.00%> (-41.87%) ⬇️
...ore/query/scheduler/resources/ResourceManager.java 84.00% <0.00%> (-12.00%) ⬇️
.../pinot/core/query/scheduler/PriorityScheduler.java 77.77% <0.00%> (-5.56%) ⬇️
...pinot/core/query/request/context/TimerContext.java 91.66% <0.00%> (-4.17%) ⬇️
...core/query/executor/ServerQueryExecutorV1Impl.java 82.99% <0.00%> (-2.64%) ⬇️
...r/validation/RealtimeSegmentValidationManager.java 71.62% <0.00%> (-1.36%) ⬇️
...nction/DistinctCountBitmapAggregationFunction.java 48.18% <0.00%> (-1.04%) ⬇️
...che/pinot/broker/routing/BrokerRoutingManager.java 85.51% <0.00%> (-0.56%) ⬇️
...server/starter/helix/HelixInstanceDataManager.java 73.91% <0.00%> (-0.49%) ⬇️
.../aggregation/function/ModeAggregationFunction.java 88.10% <0.00%> (-0.28%) ⬇️
... and 14 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@walterddr walterddr force-pushed the pr_add_generated_itcase branch from 699f594 to 602db48 Compare September 23, 2022 17:58
@walterddr walterddr force-pushed the pr_add_generated_itcase branch 4 times, most recently from 3b09545 to d51bf01 Compare September 26, 2022 15:20
@walterddr walterddr force-pushed the pr_add_generated_itcase branch from d51bf01 to a9e61ed Compare September 26, 2022 22:29
@walterddr walterddr marked this pull request as ready for review September 26, 2022 22:39
@siddharthteotia siddharthteotia merged commit b3332f1 into apache:master Sep 27, 2022
61yao pushed a commit to 61yao/pinot that referenced this pull request Oct 3, 2022
* add generated test for v2 engine

* enable integration test

* fix condition checker

Co-authored-by: Rong Rong <rongr@startree.ai>
@walterddr walterddr deleted the pr_add_generated_itcase branch December 6, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants