Always pass clientId to kafka's consumer properties#9444
Merged
npawar merged 1 commit intoapache:masterfrom Sep 21, 2022
Merged
Always pass clientId to kafka's consumer properties#9444npawar merged 1 commit intoapache:masterfrom
npawar merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@KKcorps / @saurabhd336 / @npawar : please review! and maybe, add tags as |
Codecov Report
@@ Coverage Diff @@
## master #9444 +/- ##
============================================
+ Coverage 63.57% 68.59% +5.02%
+ Complexity 4766 4704 -62
============================================
Files 1837 1890 +53
Lines 98649 100960 +2311
Branches 15086 15353 +267
============================================
+ Hits 62712 69255 +6543
+ Misses 31333 26749 -4584
- Partials 4604 4956 +352
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
KKcorps
reviewed
Sep 21, 2022
...c/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaPartitionLevelConnectionHandler.java
Show resolved
Hide resolved
KKcorps
approved these changes
Sep 21, 2022
Contributor
KKcorps
left a comment
KKcorps
left a comment
There was a problem hiding this comment.
One minor comment. Otherwise, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kafka consumer plugin doesn't pass the provided
clientIdinto the underlying consumer properties. This leads to kafka mbeans that look likeconsumer-null-87.Instead, the provided
clientIdshould always be set as a kafka consumer property.