Fix skip segment logic in MinMaxValueBasedSelectionOrderByCombineOperator#9434
Merged
siddharthteotia merged 1 commit intoapache:masterfrom Sep 20, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9434 +/- ##
============================================
- Coverage 69.82% 69.82% -0.01%
+ Complexity 5095 4715 -380
============================================
Files 1889 1889
Lines 100851 100856 +5
Branches 15328 15329 +1
============================================
+ Hits 70421 70422 +1
- Misses 25453 25465 +12
+ Partials 4977 4969 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
siddharthteotia
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9387 improves the thread usage for combine operator, but it breaks the skipping segment logic in
MinMaxValueBasedSelectionOrderByCombineOperatorwhich relies on pre-assign the segments to the thread