[multistage] test using BaseClusterIntegrationTestSet#9412
Merged
walterddr merged 6 commits intoapache:masterfrom Sep 16, 2022
Merged
[multistage] test using BaseClusterIntegrationTestSet#9412walterddr merged 6 commits intoapache:masterfrom
walterddr merged 6 commits intoapache:masterfrom
Conversation
added 4 commits
September 15, 2022 19:53
- masked out columns should not be returned. - make API more meaningful
- only tests with standard SQL - ignore non-standard SQL - add todo for tests that doesn't work
Codecov Report
@@ Coverage Diff @@
## master #9412 +/- ##
============================================
+ Coverage 69.74% 69.79% +0.04%
- Complexity 5090 5093 +3
============================================
Files 1890 1890
Lines 100683 100756 +73
Branches 15337 15350 +13
============================================
+ Hits 70220 70320 +100
+ Misses 25475 25441 -34
- Partials 4988 4995 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
walterddr
commented
Sep 16, 2022
| + "(Diff >= 300 AND Diff < 500) OR Diff < -500 ORDER BY Diff DESC"; | ||
| testQuery(query); | ||
|
|
||
| // IN_ID_SET |
Contributor
Author
There was a problem hiding this comment.
@Jackie-Jiang @61yao the following are turned of with multistage for now.
15 tasks
Jackie-Jiang
approved these changes
Sep 16, 2022
31 tasks
61yao
pushed a commit
to 61yao/pinot
that referenced
this pull request
Oct 3, 2022
by running the hard-coded queries list first - make relRoot info available in query plan - uses fields / collation / hints properly before returning results - fix SQL conformance - some other bug fixes this PR also listed out TODOs for features we don't support right now. Co-authored-by: Rong Rong <rongr@startree.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by running the hard-coded queries list first
this PR also listed out TODOs for features we don't support right now.