[multistage][bugfix] fix group-by without agg call plan failure#9383
Merged
siddharthteotia merged 2 commits intoapache:masterfrom Sep 13, 2022
Merged
[multistage][bugfix] fix group-by without agg call plan failure#9383siddharthteotia merged 2 commits intoapache:masterfrom
siddharthteotia merged 2 commits intoapache:masterfrom
Conversation
added 2 commits
September 12, 2022 10:11
83ebd3d to
af30a87
Compare
Codecov Report
@@ Coverage Diff @@
## master #9383 +/- ##
============================================
- Coverage 63.44% 61.16% -2.28%
+ Complexity 5069 4560 -509
============================================
Files 1832 1873 +41
Lines 98122 100039 +1917
Branches 15017 15238 +221
============================================
- Hits 62250 61191 -1059
- Misses 31283 34200 +2917
- Partials 4589 4648 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
31 tasks
siddharthteotia
approved these changes
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
group-by without agg call is basically a DISTINCT operation. we should allow this.