Skip to content

[multistage][bugfix] fix group-by without agg call plan failure#9383

Merged
siddharthteotia merged 2 commits intoapache:masterfrom
walterddr:pr_fix_agg_insert
Sep 13, 2022
Merged

[multistage][bugfix] fix group-by without agg call plan failure#9383
siddharthteotia merged 2 commits intoapache:masterfrom
walterddr:pr_fix_agg_insert

Conversation

@walterddr
Copy link
Contributor

group-by without agg call is basically a DISTINCT operation. we should allow this.

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2022

Codecov Report

Merging #9383 (af30a87) into master (987480b) will decrease coverage by 2.27%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #9383      +/-   ##
============================================
- Coverage     63.44%   61.16%   -2.28%     
+ Complexity     5069     4560     -509     
============================================
  Files          1832     1873      +41     
  Lines         98122   100039    +1917     
  Branches      15017    15238     +221     
============================================
- Hits          62250    61191    -1059     
- Misses        31283    34200    +2917     
- Partials       4589     4648      +59     
Flag Coverage Δ
integration1 25.96% <0.00%> (?)
unittests1 66.97% <100.00%> (+0.01%) ⬆️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../java/org/apache/pinot/query/QueryEnvironment.java 83.60% <100.00%> (+1.46%) ⬆️
...pinot/controller/recommender/io/ConfigManager.java 0.00% <0.00%> (-100.00%) ⬇️
.../org/apache/pinot/client/AggregationResultSet.java 0.00% <0.00%> (-100.00%) ⬇️
...ntroller/recommender/rules/impl/JsonIndexRule.java 0.00% <0.00%> (-100.00%) ⬇️
...troller/recommender/io/metadata/FieldMetadata.java 0.00% <0.00%> (-100.00%) ⬇️
...roller/recommender/rules/impl/BloomFilterRule.java 0.00% <0.00%> (-100.00%) ⬇️
...oller/api/resources/PinotControllerAppConfigs.java 0.00% <0.00%> (-100.00%) ⬇️
...ler/recommender/data/generator/BytesGenerator.java 0.00% <0.00%> (-100.00%) ⬇️
...er/recommender/io/metadata/SchemaWithMetaData.java 0.00% <0.00%> (-100.00%) ⬇️
...r/recommender/rules/impl/AggregateMetricsRule.java 0.00% <0.00%> (-100.00%) ⬇️
... and 558 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jackie-Jiang Jackie-Jiang added the multi-stage Related to the multi-stage query engine label Sep 13, 2022
@siddharthteotia siddharthteotia merged commit 3112cac into apache:master Sep 13, 2022
@walterddr walterddr deleted the pr_fix_agg_insert branch December 6, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

multi-stage Related to the multi-stage query engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants