Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9355 +/- ##
============================================
+ Coverage 63.38% 69.71% +6.33%
+ Complexity 4755 4710 -45
============================================
Files 1831 1890 +59
Lines 97999 100760 +2761
Branches 14990 15352 +362
============================================
+ Hits 62115 70246 +8131
+ Misses 31299 25523 -5776
- Partials 4585 4991 +406
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
KKcorps
changed the title
KKcorps
force-pushed
the
time_validation_patch
branch
from
58e966f to
f80344c
Compare
Jackie-Jiang
reviewed
Sep 9, 2022
pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFieldSpec.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFieldSpec.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java
Outdated
Show resolved
Hide resolved
KKcorps
force-pushed
the
time_validation_patch
branch
from
f80344c to
a79884e
Compare
KKcorps
force-pushed
the
time_validation_patch
branch
from
d56bd57 to
7774ed5
Compare
Jackie-Jiang
approved these changes
Sep 19, 2022
Comment on lines
+204
to
+205
| long sampleTimestampValue = (sampleValue instanceof String) ? formatSpec.fromFormatToMillis((String) sampleValue) | ||
| : formatSpec.fromFormatToMillis(String.valueOf(sampleValue)); |
Contributor
There was a problem hiding this comment.
Suggested change
| long sampleTimestampValue = (sampleValue instanceof String) ? formatSpec.fromFormatToMillis((String) sampleValue) | |
| : formatSpec.fromFormatToMillis(String.valueOf(sampleValue)); | |
| long sampleTimestampValue; | |
| try { | |
| sampleTimestampValue = formatSpec.fromFormatToMillis(sampleValue.toString()); | |
| } catch (Exception e) { | |
| throw new IllegalArgumentException(...); | |
| } |
Jackie-Jiang
added
the
Configuration
Contributor
|
Let's also update the user doc about the new field |
61yao
pushed a commit
to 61yao/pinot
that referenced
this pull request
Oct 3, 2022
* Add sample value in datetime fieldspec to check correct format * Bug fix and add test cases for sample value * Fix linting * throw exception in case of error Co-authored-by: Kartik Khare <kharekartik@Kartiks-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sampleValuefield to check the correct timestamp format during schema creation.