Skip to content

[multistage] do not pushdown inequality join rules#9328

Merged
walterddr merged 3 commits intoapache:masterfrom
walterddr:pr_fix_inequality_join
Sep 3, 2022
Merged

[multistage] do not pushdown inequality join rules#9328
walterddr merged 3 commits intoapache:masterfrom
walterddr:pr_fix_inequality_join

Conversation

@walterddr
Copy link
Contributor

@walterddr walterddr commented Sep 2, 2022

We do not support inequality join rules. thus the need to push filter into join without the inequality conditions.

@walterddr walterddr force-pushed the pr_fix_inequality_join branch from bb29688 to 921fed2 Compare September 2, 2022 15:30
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #9328 (a514802) into master (6047b06) will increase coverage by 35.11%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master    #9328       +/-   ##
=============================================
+ Coverage     28.37%   63.49%   +35.11%     
- Complexity       53     5026     +4973     
=============================================
  Files          1867     1822       -45     
  Lines         99608    97588     -2020     
  Branches      15167    14933      -234     
=============================================
+ Hits          28260    61959    +33699     
+ Misses        68608    31061    -37547     
- Partials       2740     4568     +1828     
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 67.06% <100.00%> (?)
unittests2 15.24% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../java/org/apache/pinot/query/QueryEnvironment.java 82.75% <ø> (+82.75%) ⬆️
...a/org/apache/pinot/query/planner/PlannerUtils.java 90.47% <100.00%> (+90.47%) ⬆️
...not/query/planner/logical/RelToStageConverter.java 73.91% <100.00%> (+73.91%) ⬆️
...va/org/apache/pinot/core/routing/RoutingTable.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/apache/pinot/common/config/NettyConfig.java 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/pinot/common/metrics/MinionMeter.java 0.00% <0.00%> (-100.00%) ⬇️
...g/apache/pinot/common/metrics/ControllerMeter.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/BrokerQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/MinionQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
...ache/pinot/server/access/AccessControlFactory.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1534 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@walterddr walterddr force-pushed the pr_fix_inequality_join branch from 921fed2 to ca862c0 Compare September 2, 2022 17:15
@walterddr walterddr changed the title [multistage] undo push down filter into join [multistage] do not pushdown inequality join rules Sep 2, 2022
@walterddr walterddr merged commit c3c9e2e into apache:master Sep 3, 2022
@Jackie-Jiang Jackie-Jiang added the multi-stage Related to the multi-stage query engine label Sep 13, 2022
@walterddr walterddr deleted the pr_fix_inequality_join branch December 6, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

multi-stage Related to the multi-stage query engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants