Skip to content

[array] add cardinality function #9300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
walterddr merged 3 commits into from
Sep 1, 2022
Merged

[array] add cardinality function #9300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2594305
add array cardinality
Aug 30, 2022
4a9a0d8
address diff comments
Sep 1, 2022
a7a4137
Update pinot-common/src/main/java/org/apache/pinot/common/function/Tr…
walterddr Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,9 @@ public enum TransformFunctionType {
MINUTE("minute"),
SECOND("second"),
MILLISECOND("millisecond"),
ARRAYLENGTH("arrayLength"),
// The only column accepted by "cardinality" function is multi-value array, thus putting "cardinality" as alias.
// TODO: once we support other types of multiset, we should make CARDINALITY its own function
ARRAYLENGTH("arrayLength", "cardinality"),
ARRAYAVERAGE("arrayAverage"),
ARRAYMIN("arrayMin"),
ARRAYMAX("arrayMax"),
Expand Down
3 changes: 1 addition & 2 deletions ...main/java/org/apache/pinot/core/operator/transform/function/TransformFunctionFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,7 @@ private static Map<String, Class<? extends TransformFunction>> createRegistry()
typeToImplementation.put(TransformFunctionType.MINUTE, DateTimeTransformFunction.Minute.class);
typeToImplementation.put(TransformFunctionType.SECOND, DateTimeTransformFunction.Second.class);
typeToImplementation.put(TransformFunctionType.MILLISECOND, DateTimeTransformFunction.Millisecond.class);
typeToImplementation.put(TransformFunctionType.ARRAYLENGTH,
ArrayLengthTransformFunction.class);
typeToImplementation.put(TransformFunctionType.ARRAYLENGTH, ArrayLengthTransformFunction.class);
typeToImplementation.put(TransformFunctionType.VALUEIN, ValueInTransformFunction.class);
typeToImplementation.put(TransformFunctionType.MAPVALUE, MapValueTransformFunction.class);
typeToImplementation.put(TransformFunctionType.INIDSET, InIdSetTransformFunction.class);
Expand Down
22 changes: 15 additions & 7 deletions pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,21 +613,28 @@ public void testNonAggregateMVGroupBy() {
}
{
// Test a select with a ARRAYLENGTH transform function
String query = "SELECT ARRAYLENGTH(mvRawLongCol), ARRAYLENGTH(mvLongCol) from testTable GROUP BY "
+ "ARRAYLENGTH(mvRawLongCol), ARRAYLENGTH(mvLongCol) LIMIT 10";
String query = "SELECT ARRAYLENGTH(mvRawLongCol), ARRAYLENGTH(mvLongCol), CARDINALITY(mvRawLongCol), "
+ "CARDINALITY(mvLongCol) from testTable GROUP BY ARRAYLENGTH(mvRawLongCol), ARRAYLENGTH(mvLongCol), "
+ "CARDINALITY(mvRawLongCol), CARDINALITY(mvLongCol) LIMIT 10";
ResultTable resultTable = getBrokerResponse(query).getResultTable();
assertNotNull(resultTable);
DataSchema dataSchema = new DataSchema(new String[]{"arraylength(mvRawLongCol)", "arraylength(mvLongCol)"},
new DataSchema.ColumnDataType[]{DataSchema.ColumnDataType.INT, DataSchema.ColumnDataType.INT});
DataSchema dataSchema = new DataSchema(new String[]{"arraylength(mvRawLongCol)", "arraylength(mvLongCol)",
"cardinality(mvRawLongCol)", "cardinality(mvLongCol)"},
new DataSchema.ColumnDataType[]{DataSchema.ColumnDataType.INT, DataSchema.ColumnDataType.INT,
DataSchema.ColumnDataType.INT, DataSchema.ColumnDataType.INT});
assertEquals(resultTable.getDataSchema(), dataSchema);
List<Object[]> recordRows = resultTable.getRows();
assertEquals(recordRows.size(), 1);
Object[] values = recordRows.get(0);
assertEquals(values.length, 2);
assertEquals(values.length, 4);
int intRawVal = (int) values[0];
int intVal = (int) values[1];
int intRawVal2 = (int) values[2];
int intVal2 = (int) values[3];
assertEquals(intRawVal, 2);
assertEquals(intVal, intRawVal);
assertEquals(intRawVal2, intRawVal);
assertEquals(intVal2, intRawVal);
}
}

Expand Down Expand Up @@ -937,8 +944,9 @@ public void testSelectWithFilterQueries() {
}
{
// Test a select with filter query on an arraylength transform function
String query = "SELECT mvRawIntCol, mvRawDoubleCol, mvRawStringCol from testTable where "
+ "ARRAYLENGTH(mvRawIntCol) < 5 LIMIT 10";
String query = "SELECT mvRawIntCol, mvRawDoubleCol, mvRawStringCol FROM testTable WHERE "
+ "ARRAYLENGTH(mvRawIntCol) < 5 AND CARDINALITY(mvRawIntCol) < 5 AND CARDINALITY(mvRawIntCol) < 5 "
+ "LIMIT 10";
ResultTable resultTable = getBrokerResponse(query).getResultTable();
assertNotNull(resultTable);
DataSchema dataSchema = new DataSchema(new String[]{
Expand Down