[Feature] Add an option to search input files recursively in ingestion job. The default is set to true to be backward compatible.#9265
Merged
Jackie-Jiang merged 6 commits intoapache:masterfrom Aug 24, 2022
Conversation
Contributor
Author
|
I don't think it is safe to add this flag and set the default option to false since current behavior is searching recursively by default. It is dangerous to change default behavior since we don't know what we will break. |
Contributor
Author
|
Updated the default searchRecursive option to be true. |
walterddr
reviewed
Aug 23, 2022
Contributor
walterddr
left a comment
walterddr
left a comment
There was a problem hiding this comment.
thanks for the contribution @yaostartree , this looks great overall. I have some minor comments. please kindly take a look
...-common/src/main/java/org/apache/pinot/common/segment/generation/SegmentGenerationUtils.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/test/java/org/apache/pinot/spi/ingestion/batch/IngestionJobLauncherTest.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/test/java/org/apache/pinot/spi/ingestion/batch/IngestionJobLauncherTest.java
Outdated
Show resolved
Hide resolved
61yao
changed the title
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Good job extracting the common code into the util
Is the pinot-plugins.tar.gz file required for this PR? I feel it is mistakenly included
...in/java/org/apache/pinot/plugin/ingestion/batch/hadoop/HadoopSegmentGenerationJobRunner.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/spec/SegmentGenerationJobSpec.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/spec/SegmentGenerationJobSpec.java
Outdated
Show resolved
Hide resolved
...-common/src/main/java/org/apache/pinot/common/segment/generation/SegmentGenerationUtils.java
Outdated
Show resolved
Hide resolved
...-common/src/main/java/org/apache/pinot/common/segment/generation/SegmentGenerationUtils.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/pinot/plugin/ingestion/batch/spark/SparkSegmentGenerationJobRunner.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/pinot/plugin/ingestion/batch/spark3/SparkSegmentGenerationJobRunner.java
Outdated
Show resolved
Hide resolved
...-common/src/main/java/org/apache/pinot/common/segment/generation/SegmentGenerationUtils.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/BatchConfig.java
Outdated
Show resolved
Hide resolved
61yao
force-pushed
the
recursive_flag
branch
2 times, most recently
from
a5082ad to
da7aad0
Compare
Contributor
Author
|
Yeah. Removed the pinot-plugins.tar.gz |
Jackie-Jiang
added
the
release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
searchRecursively option is added in jobSpec. It is added to prevent the non-necessary recursive search for input files.
Currently, the option is set to true by default since that is existing behavior.
In next PR, we will change the default to be false after clients are aware of this change.