use default authorization behavior for zk user config#9251
Closed
use default authorization behavior for zk user config#9251
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9251 +/- ##
============================================
- Coverage 69.91% 67.09% -2.82%
- Complexity 4764 4815 +51
============================================
Files 1858 1381 -477
Lines 99187 71947 -27240
Branches 15087 11520 -3567
============================================
- Hits 69346 48275 -21071
+ Misses 24930 20168 -4762
+ Partials 4911 3504 -1407
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
approved these changes
Aug 22, 2022
Contributor
Author
|
included in #9252 |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor refactor of
PinotAccessControlUserRestletResourceto rely on the AuthFilter's default behavior rather than performing authorization manually.CC: original author @Innocent-Boy, any subtle issues you see with this?