Add support for Auth in controller requests in java query client#9230
Merged
KKcorps merged 3 commits intoapache:masterfrom Sep 7, 2022
Merged
Add support for Auth in controller requests in java query client#9230KKcorps merged 3 commits intoapache:masterfrom
KKcorps merged 3 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9230 +/- ##
=============================================
- Coverage 69.88% 26.23% -43.65%
+ Complexity 5008 44 -4964
=============================================
Files 1854 1845 -9
Lines 98871 98633 -238
Branches 15043 15011 -32
=============================================
- Hits 69094 25875 -43219
- Misses 24904 70194 +45290
+ Partials 4873 2564 -2309
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiangfu0
reviewed
Sep 7, 2022
xiangfu0
approved these changes
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds the support for auth and https when using
fromControllerof java client.The PR also does refactor some interfaces while maintaining backwards compatibility
JsonAsyncHttpPinotClientTransportFactoryis refactored to initiate all the configs such as headers, scheme etc. fromPropertiesobject itself. This is done so that end user doesn't have to create and pass a new transport object if they want to enable https or auth.fromZookeeper,fromBrokerListetc.