add /tasks/{taskType}/{tableNameWithType}/debug API#8949
Merged
npawar merged 4 commits intoapache:masterfrom Jun 22, 2022
Merged
add /tasks/{taskType}/{tableNameWithType}/debug API#8949npawar merged 4 commits intoapache:masterfrom
npawar merged 4 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8949 +/- ##
============================================
- Coverage 69.69% 66.26% -3.43%
+ Complexity 4715 4695 -20
============================================
Files 1813 1361 -452
Lines 94503 68700 -25803
Branches 14117 10746 -3371
============================================
- Hits 65860 45523 -20337
+ Misses 24039 19899 -4140
+ Partials 4604 3278 -1326
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
npawar
reviewed
Jun 21, 2022
| String tableNameWithType, | ||
| @ApiParam(value = "verbosity (By default, prints for running and error tasks. Value of >0 prints for all tasks)") | ||
| @DefaultValue("0") @QueryParam("verbosity") int verbosity) { | ||
| return _pinotHelixTaskResourceManager.getTasksDebugInfoByTable(taskType, tableNameWithType, verbosity); |
Contributor
There was a problem hiding this comment.
I tried this out with RealtimeQuickstartWithMinion, and saw it return 3 COMPLETED tasks, for both 0 and 1 verbosity. Only difference was level of detail. Is this By default, prints for running and error tasks. Value of >0 prints for all tasks) incorrect or does the impl need some change?
Contributor
Author
There was a problem hiding this comment.
simply copied and pasted the existing docs 😄 . fixed this one and existing ones.
| String tableNameConfig = pinotConfigs.get(TABLE_NAME); | ||
| if (tableNameConfig != null && tableNameConfig.equals(tableNameWithType)) { | ||
| // Found a match. Add task debug info to the result | ||
| // TODO: we may want to filter out debug info that does not belong to the given table. |
Contributor
There was a problem hiding this comment.
didn't follow this TODO. why would we get info from getTaskDebugInfo that's not for this table?
Contributor
Author
There was a problem hiding this comment.
updated the TODO.
Contributor
Mind adding a sample response here? |
npawar
added
enhancement
release-notes
Contributor
Author
|
Sample response when verbosity = 0
|
Contributor
Author
|
Sample response when verbosity = 1
|
npawar
approved these changes
Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Add /tasks/{taskType}/{tableNameWithType}/debug API so that we can get a task debug info for the given table. This makes debugging a specific table's problem easier.
Test
Test by setting up a Pinot cluster locally.