Defined a new broker metric for total query processing time #8941
Merged
npawar merged 3 commits intoapache:masterfrom Jun 24, 2022
Merged
Defined a new broker metric for total query processing time #8941npawar merged 3 commits intoapache:masterfrom
npawar merged 3 commits intoapache:masterfrom
Conversation
… metric to broker.yaml
Contributor
Author
|
Review pls : @npawar |
npawar
added
release-notes
npawar
reviewed
Jun 21, 2022
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
Member
|
How is this different from the totaltimems that we have today? |
Contributor
Author
Are you referring to So, it is not the total query processing time. Total query time should start from the request compilation phase and all the way to the end. |
npawar
approved these changes
Jun 22, 2022
Contributor
Author
|
@npawar can you merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Defined a new broker metric for total query processing time and added metric to broker.yaml
Tags to include:
observability,release notesRelease Notes:
Includes a new broker timer type metric -
queryTotalTimeMs