Spark Connector, support for TIMESTAMP and BOOLEAN fields#8825
Merged
yupeng9 merged 5 commits intoapache:masterfrom Jun 4, 2022
Merged
Spark Connector, support for TIMESTAMP and BOOLEAN fields#8825yupeng9 merged 5 commits intoapache:masterfrom
yupeng9 merged 5 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8825 +/- ##
=============================================
- Coverage 68.15% 25.75% -42.40%
+ Complexity 4626 45 -4581
=============================================
Files 1735 1729 -6
Lines 91298 91124 -174
Branches 13636 13636
=============================================
- Hits 62226 23473 -38753
- Misses 24733 65384 +40651
+ Partials 4339 2267 -2072
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
KKcorps
approved these changes
Jun 3, 2022
yupeng9
approved these changes
Jun 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Spark Connector doesn't support TIMESTAMP and BOOLEAN field types, which were introduced to Pinot after the connector was added. I'm adding mapping for singular and array variations of these types.
New field type mappings:
Discussion
Spark also supports a TimestampType which is backed by "Long" and stores milliseconds since epoch as explained here. It could have been a better choice from Pinot
TIMESTAMPfield, however I had a hard time correctly translating the Pinot value to microseconds for allTIMESTAMPcolumn. I'm open to suggestions here, would like to know if there is an easy way.Testing
Backwards Compatibility
No previous behavior is broken with the introduction of these fields. Previously the connector would throw an exception when it came across these unknown Pinot field types.
bugfixfeature