Revert "Allow moveToFinalLocation in METADATA push based on config"

[npawar]

Reverts #8815
Based on discussion in PR, the new mode copies an incorrect copy of the segment.

[codecov-commenter]

Codecov Report

Merging #8822 (066a8a4) into master (7a31142) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 066a8a4 differs from pull request most recent head cdfc4db. Consider uploading reports for the commit cdfc4db to get more accurate results

@@             Coverage Diff              @@
##             master    #8822      +/-   ##
============================================
+ Coverage     69.72%   69.75%   +0.02%     
+ Complexity     4659     4656       -3     
============================================
  Files          1741     1741              
  Lines         91477    91467      -10     
  Branches      13674    13672       -2     
============================================
+ Hits          63779    63799      +20     
+ Misses        23269    23243      -26     
+ Partials       4429     4425       -4     

Flag	Coverage Δ
integration1	27.02% <100.00%> (+0.05%)	⬆️
integration2	25.63% <100.00%> (+0.03%)	⬆️
unittests1	66.22% <ø> (+<0.01%)	⬆️
unittests2	14.13% <0.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...e/pinot/common/utils/FileUploadDownloadClient.java	59.42% <ø> (ø)
...he/pinot/segment/local/utils/SegmentPushUtils.java	12.70% <ø> (+0.20%)	⬆️
...he/pinot/spi/ingestion/batch/spec/PushJobSpec.java	59.09% <ø> (+7.09%)	⬆️
...ces/PinotSegmentUploadDownloadRestletResource.java	54.43% <100.00%> (-1.18%)	⬇️
...he/pinot/segment/local/segment/store/IndexKey.java	65.00% <0.00%> (-15.00%)	⬇️
...mmon/request/context/predicate/NotEqPredicate.java	84.61% <0.00%> (-7.70%)	⬇️
...or/transform/function/IsNullTransformFunction.java	78.57% <0.00%> (-7.15%)	⬇️
...transform/function/IsNotNullTransformFunction.java	67.85% <0.00%> (-7.15%)	⬇️
.../filter/predicate/InPredicateEvaluatorFactory.java	70.45% <0.00%> (-4.55%)	⬇️
...ders/forward/VarByteChunkMVForwardIndexReader.java	93.05% <0.00%> (-2.78%)	⬇️
... and 22 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a31142...cdfc4db. Read the comment docs.