Address comments for DoubleVectorOpUtils#8777
Merged
siddharthteotia merged 1 commit intoapache:masterfrom May 26, 2022
Merged
Conversation
Jackie-Jiang
approved these changes
May 25, 2022
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/utils/DoubleVectorOpUtils.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8777 +/- ##
============================================
+ Coverage 25.36% 29.19% +3.83%
Complexity 45 45
============================================
Files 1724 1724
Lines 90820 90843 +23
Branches 13592 13595 +3
============================================
+ Hits 23037 26524 +3487
+ Misses 65558 61870 -3688
- Partials 2225 2449 +224
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the comments in #8724 (comment)
@Jackie-Jiang