Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Add star-tree test for unsupported filters #8733

Merged
merged 1 commit into from
May 19, 2022

Conversation

Jackie-Jiang
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang commented May 19, 2022

There is a bug introduced in #7184 (Atri and I collaborated on that PR, and the bug is introduced by my commit) that will cause Pinot using star-tree to solve queries that it cannot solve, and is fixed here (under a different feature support). This PR adds some test cases to prevent the regression in the future.

@Jackie-Jiang Jackie-Jiang requested review from atris and mayankshriv May 19, 2022 01:11
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #8733 (4886b67) into master (b4c4585) will decrease coverage by 44.49%.
The diff coverage is n/a.

❗ Current head 4886b67 differs from pull request most recent head 0909542. Consider uploading reports for the commit 0909542 to get more accurate results

@@              Coverage Diff              @@
##             master    #8733       +/-   ##
=============================================
- Coverage     69.67%   25.18%   -44.50%     
+ Complexity     4612       45     -4567     
=============================================
  Files          1730     1718       -12     
  Lines         90312    89958      -354     
  Branches      13421    13383       -38     
=============================================
- Hits          62928    22657    -40271     
- Misses        23015    65121    +42106     
+ Partials       4369     2180     -2189     
Flag Coverage Δ
integration1 ?
integration2 25.18% <ø> (+0.01%) ⬆️
unittests1 ?
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/java/org/apache/pinot/spi/utils/StringUtil.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/spi/utils/BooleanUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/BaseRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/NoOpRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/table/FSTType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/user/RoleType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/data/MetricFieldSpec.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/tier/TierFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/pinot/spi/config/table/TableType.java 0.00% <0.00%> (-100.00%) ⬇️
.../org/apache/pinot/spi/data/DimensionFieldSpec.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1246 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4c4585...0909542. Read the comment docs.

@Jackie-Jiang Jackie-Jiang merged commit c50b3c4 into apache:master May 19, 2022
@Jackie-Jiang Jackie-Jiang deleted the fix_startree_or branch May 19, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants