Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HELM] .gitignore should include helm generated files #8728

Merged
merged 1 commit into from
May 18, 2022

Conversation

walterddr
Copy link
Contributor

*.lock and charts/* are generated files when running helm commands.

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #8728 (ddc2e78) into master (b672af1) will increase coverage by 6.87%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8728      +/-   ##
============================================
+ Coverage     62.81%   69.69%   +6.87%     
- Complexity     4556     4614      +58     
============================================
  Files          1679     1730      +51     
  Lines         88125    90341    +2216     
  Branches      13198    13442     +244     
============================================
+ Hits          55354    62961    +7607     
+ Misses        28801    23011    -5790     
- Partials       3970     4369     +399     
Flag Coverage Δ
integration1 26.91% <ø> (?)
integration2 25.28% <ø> (?)
unittests1 66.21% <ø> (+0.02%) ⬆️
unittests2 14.23% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...che/pinot/segment/spi/index/reader/Dictionary.java 82.14% <0.00%> (-13.70%) ⬇️
...t/local/segment/index/readers/FloatDictionary.java 91.66% <0.00%> (-8.34%) ⬇️
.../local/segment/index/readers/DoubleDictionary.java 91.66% <0.00%> (-8.34%) ⬇️
...ders/forward/VarByteChunkMVForwardIndexReader.java 93.05% <0.00%> (-2.78%) ⬇️
...g/apache/pinot/spi/utils/IngestionConfigUtils.java 73.33% <0.00%> (-2.73%) ⬇️
...ata/manager/offline/DimensionTableDataManager.java 82.14% <0.00%> (-2.48%) ⬇️
...r/api/resources/PinotIngestionRestletResource.java 55.26% <0.00%> (-1.15%) ⬇️
...org/apache/pinot/core/common/ObjectSerDeUtils.java 89.57% <0.00%> (-0.82%) ⬇️
.../aggregation/function/ModeAggregationFunction.java 88.10% <0.00%> (-0.55%) ⬇️
...he/pinot/segment/local/utils/SegmentPushUtils.java 12.70% <0.00%> (-0.22%) ⬇️
... and 421 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b672af1...ddc2e78. Read the comment docs.

@xiangfu0 xiangfu0 merged commit 1009159 into apache:master May 18, 2022
@walterddr walterddr deleted the gitignore_helm branch December 6, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants