Scalable Gapfill Implementation for Avg/Count/Sum#8647
Merged
Jackie-Jiang merged 38 commits intoapache:masterfrom May 16, 2022
Merged
Scalable Gapfill Implementation for Avg/Count/Sum#8647Jackie-Jiang merged 38 commits intoapache:masterfrom
Jackie-Jiang merged 38 commits intoapache:masterfrom
Conversation
This reverts commit 74ac4d2.
Codecov Report
@@ Coverage Diff @@
## master #8647 +/- ##
============================================
- Coverage 66.16% 62.88% -3.29%
- Complexity 4387 4554 +167
============================================
Files 1277 1681 +404
Lines 64430 88120 +23690
Branches 10014 13178 +3164
============================================
+ Hits 42633 55413 +12780
- Misses 18786 28735 +9949
- Partials 3011 3972 +961
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Jackie-Jiang
reviewed
May 9, 2022
...t-core/src/main/java/org/apache/pinot/core/query/reduce/ScalableGapfillProcessorFactory.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/ScalableGapfillProcessor.java
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/ScalableGapfillProcessor.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/org/apache/pinot/core/query/reduce/ScalableGapfillProcessorForCount.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the performance optimization for avg/count/sum aggregation of gap filled result. These aggregation functions are about counting. It is time-consuming to create the gapfilled rows when doing the aggregation. This PR will not create the gap filled rows when doing the counting. This will give 10x performance improvement.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation