Support BigDecimal raw value forward index; Support BigDecimal in many transforms and operators#8622
Merged
Jackie-Jiang merged 4 commits intoapache:masterfrom May 3, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8622 +/- ##
=============================================
- Coverage 70.47% 25.55% -44.93%
=============================================
Files 1703 1694 -9
Lines 89569 89707 +138
Branches 13564 13625 +61
=============================================
- Hits 63123 22923 -40200
- Misses 21990 64558 +42568
+ Partials 4456 2226 -2230
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Jackie-Jiang
reviewed
May 2, 2022
Contributor
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Mostly good, awesome work!
...a/org/apache/pinot/core/operator/transform/function/SelectTupleElementTransformFunction.java
Outdated
Show resolved
Hide resolved
...java/org/apache/pinot/core/operator/transform/function/SingleParamMathTransformFunction.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/pinot/core/operator/transform/function/DivisionTransformFunction.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/pinot/core/operator/transform/function/SubtractionTransformFunction.java
Outdated
Show resolved
Hide resolved
|
|
||
| public void putBigDecimal(BigDecimal value) { | ||
| _chunkBuffer.put(BigDecimalUtils.serialize(value)); | ||
| _chunkDataOffset += BigDecimalUtils.byteSize(value); |
Contributor
There was a problem hiding this comment.
Put the serialized bytes length here instead of re-calculating the byte size again
...in/java/org/apache/pinot/segment/local/segment/creator/impl/DefaultIndexCreatorProvider.java
Show resolved
Hide resolved
...java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java
Show resolved
Hide resolved
...apache/pinot/segment/local/segment/creator/impl/fwd/SingleValueFixedByteRawIndexCreator.java
Outdated
Show resolved
Hide resolved
...g/apache/pinot/segment/local/segment/creator/impl/fwd/SingleValueVarByteRawIndexCreator.java
Outdated
Show resolved
Hide resolved
...ache/pinot/segment/local/segment/index/readers/forward/VarByteChunkSVForwardIndexReader.java
Outdated
Show resolved
Hide resolved
Jackie-Jiang
approved these changes
May 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature,release-notes