Use MultiThreadedHttpConnectionManager in SegmentStatusChecker#8568
Merged
siddharthteotia merged 1 commit intoapache:masterfrom Apr 20, 2022
Merged
Use MultiThreadedHttpConnectionManager in SegmentStatusChecker#8568siddharthteotia merged 1 commit intoapache:masterfrom
siddharthteotia merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@siddharthteotia @mcvsubbu please review. |
siddharthteotia
approved these changes
Apr 20, 2022
Currently, SegmentStatusChecker initializes an object of type SimpleHttpConnectionManager. Further down the stack, we use this object to issue parallel HTTP GET requests to multiple servers containing segments for the table (in MultiGetRequest). However, SimpleHttpConnectionManager is not thread safe. So we should be using an instance of MultithreadedHttpConnectionManager. Added a TODO to improve MultiGetRequest.java to only work on HttpConnectionManager object that is an instanceOf MultithreadedHttpConnectionManager.
vvivekiyer
force-pushed
the
http_connection_manager
branch
from
fb26ceb to
5c86463
Compare
Codecov Report
@@ Coverage Diff @@
## master #8568 +/- ##
============================================
- Coverage 70.83% 70.81% -0.03%
- Complexity 4291 4307 +16
============================================
Files 1686 1688 +2
Lines 88226 88295 +69
Branches 13351 13358 +7
============================================
+ Hits 62492 62522 +30
- Misses 21362 21408 +46
+ Partials 4372 4365 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, SegmentStatusChecker initializes an object of type
SimpleHttpConnectionManager. Further down the stack, we use this object to
issue parallel HTTP GET requests to multiple servers containing segments for
the table (in MultiGetRequest). However, SimpleHttpConnectionManager is not
thread safe. So we should be using an instance of MultithreadedHttpConnectionManager.
Added a TODO to improve MultiGetRequest.java to only work on HttpConnectionManager
object that is an instanceOf MultithreadedHttpConnectionManager.
PR where the issue was introduced - #8358