Simplify the parameters for DistinctCountSmartHLLAggregationFunction#8566
Merged
siddharthteotia merged 1 commit intoapache:masterfrom Apr 20, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8566 +/- ##
=============================================
- Coverage 70.83% 36.72% -34.11%
+ Complexity 4291 84 -4207
=============================================
Files 1686 1687 +1
Lines 88226 88248 +22
Branches 13351 13352 +1
=============================================
- Hits 62492 32407 -30085
- Misses 21362 53216 +31854
+ Partials 4372 2625 -1747
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xiangfu0
approved these changes
Apr 19, 2022
siddharthteotia
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the parameters for the
DistinctCountSmartHLLAggregationFunctionis too long and can be hard to use. Since they are always under the scope of the function, we may simplify them for usability. The old parameter keys are still supported.Release Notes
Change the following parameter keys for
DISTINCT_COUNT_SMART_HLLaggregation function:hllConversionThreshold->thresholdhllLog2m->log2m