You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging #8560 (f347137) into master (e8f9d88) will decrease coverage by 5.68%.
The diff coverage is n/a.
❗ Current head f347137 differs from pull request most recent head c8e04a3. Consider uploading reports for the commit c8e04a3 to get more accurate results
@xiangfu0@Jackie-Jiang Seems like adding spark tests might not be possible in spark3.2 module. Reason being the conflicts in commons-lang3 and Jackson version.
The plugin works because of shading which is not enforced during test phase.
@xiangfu0@Jackie-Jiang Seems like adding spark tests might not be possible in spark3.2 module. Reason being the conflicts in commons-lang3 and Jackson version. The plugin works because of shading which is not enforced during test phase.
Then should you update the dependency version for commons-lang3 and Jackson version in the Spark 3.2 module?
Maven enforcer won't allow that right. Using different versions for a dependency. If it did, I would simply use the required versions here and shade them with spark3 prefix.
Maven enforcer won't allow that right. Using different versions for a dependency. If it did, I would simply use the required versions here and shade them with spark3 prefix.
You need to exclude those dependencies to make enforcer check pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Spark 3.2.1 in Pinot.
Changes done
Verified in local with the following command from the documentation