Refactor getMin/getMax value to IndexCreationContext from Range#8442
Merged
xiangfu0 merged 1 commit intoapache:masterfrom Mar 30, 2022
Merged
Conversation
richardstartin
approved these changes
Mar 30, 2022
xiangfu0
force-pushed
the
move_min_max_value_to_IndexCreationContext
branch
from
17d43c9 to
99ab07d
Compare
Codecov Report
@@ Coverage Diff @@
## master #8442 +/- ##
============================================
+ Coverage 67.03% 69.36% +2.33%
- Complexity 4196 4284 +88
============================================
Files 1259 1662 +403
Lines 63519 87227 +23708
Branches 9935 13205 +3270
============================================
+ Hits 42577 60505 +17928
- Misses 17896 22469 +4573
- Partials 3046 4253 +1207
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor getMin/getMax value to IndexCreationContext from Range
Part of effort to make #8343 smaller.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation