Adding new field expressionOverrideHints into PinotQuery#8421
Merged
xiangfu0 merged 1 commit intoapache:masterfrom Mar 28, 2022
Merged
Adding new field expressionOverrideHints into PinotQuery#8421xiangfu0 merged 1 commit intoapache:masterfrom
xiangfu0 merged 1 commit intoapache:masterfrom
Conversation
xiangfu0
force-pushed
the
pinotquery-thrift
branch
from
60547d7 to
35a48f4
Compare
Codecov Report
@@ Coverage Diff @@
## master #8421 +/- ##
============================================
+ Coverage 70.79% 70.83% +0.04%
Complexity 4281 4281
============================================
Files 1655 1655
Lines 86665 86665
Branches 13067 13067
============================================
+ Hits 61353 61392 +39
+ Misses 21071 21034 -37
+ Partials 4241 4239 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xiangfu0
force-pushed
the
pinotquery-thrift
branch
from
35a48f4 to
6f60343
Compare
Jackie-Jiang
approved these changes
Mar 28, 2022
| * | ||
| */ | ||
| @javax.annotation.Generated(value = "Autogenerated by Thrift Compiler (0.13.0)", date = "2021-09-28") | ||
| @javax.annotation.Generated(value = "Autogenerated by Thrift Compiler (0.13.0)", date = "2022-03-28") |
Contributor
There was a problem hiding this comment.
Since we have upgraded thrift to 0.15.0, consider re-compiling the files with 0.15.0
Contributor
Author
There was a problem hiding this comment.
hmm, maybe do it in another PR for thrift upgrade?
Contributor
Author
There was a problem hiding this comment.
I will submit the new PR after this.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is to enable best-effort query rewrite at the segment level. The hint is computed at the broker and passed through to all the servers and applied to each segment for further processing.
Note that the generated java files don't follow the Pinot code style, so I modified them a bit.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation