You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #7269 we added support for null time handling, but with 2 limitations:
It is not enabled by default
It does not support custom default value
This PR addressed these 2 limitations by checking if the default value complies with the time format and is in valid time range (1971-01-01 to 2071-01-01). If so, use the custom default value; if not, fall back to the current time.
Release Notes
Removed config allowNullTimeValue from the segmentsConfig, and null time values are always filled with default values
@mcvsubbu It should have the same behavior as setting allowNullTimeValue before (always enabled). The only difference is that when users explicitly put the default value, we will fill the default value instead of the current time, which is the expected behavior. Do you run into issues regarding this feature?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
featurerelease-notesReferenced by PRs that need attention when compiling the next release notes
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7269 we added support for null time handling, but with 2 limitations:
This PR addressed these 2 limitations by checking if the default value complies with the time format and is in valid time range (1971-01-01 to 2071-01-01). If so, use the custom default value; if not, fall back to the current time.
Release Notes
Removed config
allowNullTimeValuefrom thesegmentsConfig, andnulltime values are always filled with default values