Move TLS configs and utils from pinot-core to pinot-common#8210
Merged
xiangfu0 merged 1 commit intoapache:masterfrom Feb 16, 2022
Merged
Move TLS configs and utils from pinot-core to pinot-common#8210xiangfu0 merged 1 commit intoapache:masterfrom
xiangfu0 merged 1 commit intoapache:masterfrom
Conversation
xiangfu0
force-pushed
the
move_tls_configs_to_common
branch
2 times, most recently
from
2d17ffc to
f79499d
Compare
xiangfu0
force-pushed
the
move_tls_configs_to_common
branch
from
f79499d to
675acc0
Compare
Codecov Report
@@ Coverage Diff @@
## master #8210 +/- ##
=============================================
- Coverage 70.97% 14.12% -56.85%
+ Complexity 4313 81 -4232
=============================================
Files 1626 1581 -45
Lines 84851 83048 -1803
Branches 12790 12579 -211
=============================================
- Hits 60221 11730 -48491
- Misses 20496 70438 +49942
+ Partials 4134 880 -3254
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
apucher
approved these changes
Feb 16, 2022
Contributor
apucher
left a comment
apucher
left a comment
There was a problem hiding this comment.
looks good from my side.
However, I'd add to the release notes that this could break 3rd party code extension that use TlsUtils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
So TLS configs can be reused by the gRPC client as well
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Backward incompatible for 3rd party code extension:
TlsUtilsis moved fromorg.apache.pinot.core.util.TlsUtilstoorg.apache.pinot.common.utils.TlsUtilsDocumentation