Optimize geometry serializer usage when literal is available#8167
Merged
Jackie-Jiang merged 4 commits intoapache:masterfrom Feb 15, 2022
Merged
Optimize geometry serializer usage when literal is available#8167Jackie-Jiang merged 4 commits intoapache:masterfrom
Jackie-Jiang merged 4 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8167 +/- ##
============================================
- Coverage 71.01% 64.36% -6.65%
Complexity 4314 4314
============================================
Files 1624 1580 -44
Lines 84873 82964 -1909
Branches 12791 12584 -207
============================================
- Hits 60273 53402 -6871
- Misses 20453 25744 +5291
+ Partials 4147 3818 -329
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
walterddr
changed the title
walterddr
force-pushed
the
optimize_st_literal
branch
2 times, most recently
from
a50d4a9 to
b38053d
Compare
...java/org/apache/pinot/core/geospatial/transform/function/BaseBinaryGeoTransformFunction.java
Outdated
Show resolved
Hide resolved
...java/org/apache/pinot/core/geospatial/transform/function/BaseBinaryGeoTransformFunction.java
Outdated
Show resolved
Hide resolved
...java/org/apache/pinot/core/geospatial/transform/function/BaseBinaryGeoTransformFunction.java
Outdated
Show resolved
Hide resolved
...java/org/apache/pinot/core/geospatial/transform/function/BaseBinaryGeoTransformFunction.java
Outdated
Show resolved
Hide resolved
...java/org/apache/pinot/core/geospatial/transform/function/BaseBinaryGeoTransformFunction.java
Outdated
Show resolved
Hide resolved
walterddr
force-pushed
the
optimize_st_literal
branch
from
7c7acf9 to
3dd8913
Compare
walterddr
force-pushed
the
optimize_st_literal
branch
from
3dd8913 to
c11d097
Compare
Jackie-Jiang
approved these changes
Feb 15, 2022
xiangfu0
pushed a commit
to xiangfu0/pinot
that referenced
this pull request
Feb 23, 2022
…8167) Cache the Literal converted Geometry instead of computing it each time the Geometry function is called. This - save memory for processing literal transform function (previously it was done via Array.fill) - save compute from Geometry function In general this should apply to any chained call to LiteralTransformFunction with block --> it should be considered as a fake array instead fo a real, replicated one. This is out of scope of this PR but something to keep in mind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache the Literal converted Geometry instead of computing it each time the Geometry function is called.
This
In general this should apply to any chained call to LiteralTransformFunction with block --> it should be considered as a fake array instead fo a real, replicated one. This is out of scope of this PR but something to keep in mind.