Add allowRefresh option to UploadSegment#8125
Merged
siddharthteotia merged 3 commits intoapache:masterfrom Feb 7, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8125 +/- ##
============================================
- Coverage 71.39% 64.74% -6.66%
+ Complexity 4303 4302 -1
============================================
Files 1624 1579 -45
Lines 84198 82322 -1876
Branches 12602 12399 -203
============================================
- Hits 60116 53300 -6816
- Misses 19970 25228 +5258
+ Partials 4112 3794 -318
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Jackie-Jiang
reviewed
Feb 4, 2022
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Overriding a segment is called refresh in pinot. Consider naming the parameter allowRefresh?
vvivekiyer
changed the title
Contributor
|
@kkrugler Please take a look at this PR. Note that our requirement for this is very specific -- for cloud data migration from on-prem where newer segment may have already landed on Azure and the migration script should honor that and not overwrite. |
Contributor
Author
|
Renamed the parameter to allowRefresh. @Jackie-Jiang please take a look. |
added 3 commits
February 7, 2022 17:40
Currently, when a segment is uploaded, we always overwrite if a segment with the same name already exists. Having an overwrite parameter in the UploadSegment API will give clients finer control during uploading segments. Note that the default option is set to true to retain existing behavior.
- Improve description for a method. - Add message when exception is thrown.
siddharthteotia
approved these changes
Feb 7, 2022
Jackie-Jiang
approved these changes
Feb 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when a segment is uploaded, we always overwrite if a
segment with the same name already exists. Having an overwrite
parameter in the UploadSegment API will give clients finer
control during uploading segments.
Note that the default value is set to true to retain existing
behavior.