Skip to content

reduce allocations and speed up StringUtil.sanitizeString #8013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
npawar merged 1 commit into from
Jan 13, 2022
Merged

reduce allocations and speed up StringUtil.sanitizeString #8013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions pinot-common/src/main/java/org/apache/pinot/common/utils/StringUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ public class StringUtil {
private StringUtil() {
}

private static final char NULL_CHARACTER = '\0';
// prefer string to character because String.indexOf(String) is a fast intrinsic on all JDK versions
private static final String NULL_CHARACTER = "\0";

/**
* Joins the given keys with the separator.
Expand All @@ -47,18 +48,10 @@ public static String join(String separator, String... keys) {
* @return Modified value, or value itself if not modified
*/
public static String sanitizeStringValue(String value, int maxLength) {
char[] chars = value.toCharArray();
int length = chars.length;
int limit = Math.min(length, maxLength);
for (int i = 0; i < limit; i++) {
if (chars[i] == NULL_CHARACTER) {
return new String(chars, 0, i);
}
}
if (limit < length) {
return new String(chars, 0, limit);
} else {
return value;
int index = value.indexOf(NULL_CHARACTER);
if (index < 0) {
return value.length() <= maxLength ? value : value.substring(0, maxLength);
}
return value.substring(0, Math.min(index, maxLength));
}
}