add ability to comment out queries with cmd + /#7841
Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom Dec 1, 2021
jadami10:jadami/command-slash-comment
Merged
add ability to comment out queries with cmd + /#7841Jackie-Jiang merged 1 commit intoapache:masterfrom jadami10:jadami/command-slash-comment
Jackie-Jiang merged 1 commit intoapache:masterfrom
jadami10:jadami/command-slash-comment
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7841 +/- ##
============================================
- Coverage 71.67% 65.22% -6.46%
+ Complexity 4089 4088 -1
============================================
Files 1579 1534 -45
Lines 80843 78981 -1862
Branches 12010 11814 -196
============================================
- Hits 57944 51514 -6430
- Misses 18995 23791 +4796
+ Partials 3904 3676 -228
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kriti-sc
pushed a commit
to kriti-sc/incubator-pinot
that referenced
this pull request
Dec 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I had some extra time, and this has been bothering me, so I decided to add it. Doing
cmd + /in the query console now will add/remove--before the lines.A video is probably best here
This doesn't handle resetting selection mostly because I didn't feel like going down that road. I think this is a good start for now for the query console.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation