Handle null segment lineage ZNRecord for getSelectedSegments API #7752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtao15
reviewed
Nov 11, 2021
...ntroller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
Outdated
Show resolved
Hide resolved
jackjlli
force-pushed
the
handle-null-segment-lineage
branch
from
31fe098 to
ccd58ac
Compare
jackjlli
force-pushed
the
handle-null-segment-lineage
branch
from
ccd58ac to
8743bab
Compare
|
LGTM |
snleee
reviewed
Nov 11, 2021
...ntroller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #7752 +/- ##
============================================
- Coverage 71.49% 65.12% -6.37%
+ Complexity 4064 4063 -1
============================================
Files 1577 1531 -46
Lines 80554 78675 -1879
Branches 11965 11766 -199
============================================
- Hits 57592 51241 -6351
- Misses 19078 23792 +4714
+ Partials 3884 3642 -242
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
snleee
approved these changes
Nov 11, 2021
kriti-sc
pushed a commit
to kriti-sc/incubator-pinot
that referenced
this pull request
Dec 12, 2021
…che#7752) Co-authored-by: Jack Li(Analytics Engineering) <jlli@jlli-mn1.linkedin.biz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR handles null segment lineage ZNRecord for getSelectedSegments API. When the ZNRecord is null, we don't need to filter any segments and directly return the selected segments to the client side.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation