Separate SegmentDirectoryLoader and tierBackend concepts #7737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishoreg
approved these changes
Nov 9, 2021
Codecov Report
@@ Coverage Diff @@
## master #7737 +/- ##
============================================
+ Coverage 70.18% 71.35% +1.17%
Complexity 4034 4034
============================================
Files 1575 1575
Lines 80289 80298 +9
Branches 11938 11938
============================================
+ Hits 56353 57300 +947
+ Misses 20061 19112 -949
- Partials 3875 3886 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
klsince
reviewed
Nov 10, 2021
| */ | ||
| public static SegmentDirectoryLoader getSegmentDirectoryLoader(String tierBackend) { | ||
| return SEGMENT_DIRECTORY_LOADER_MAP.get(tierBackend); | ||
| public static void setSegmentDirectoryLoader(String segmentDirectoryLoaderName, SegmentDirectoryLoader loader) { |
kriti-sc
pushed a commit
to kriti-sc/incubator-pinot
that referenced
this pull request
Dec 12, 2021
Right now the concept of tier storage backend and segmentDirectoryLoader have gotten mixed. Cleaning that up to have SegmentDirectoryLoader identifiable by the segment.directory.loader property and moving tier.backend and tier.properties to the table config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the concept of tier storage backend and segmentDirectoryLoader have gotten mixed. Cleaning that up to have SegmentDirectoryLoader identifiable by the
segment.directory.loaderproperty and movingtier.backendandtier.propertiesto the table config.