Allow override distinctCount to segmentPartitionedDistinctCount #7664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
force-pushed
the
override_distinct_count_function_for_table_column
branch
3 times, most recently
from
6cb2e35 to
490a4e0
Compare
Codecov Report
@@ Coverage Diff @@
## master #7664 +/- ##
=============================================
- Coverage 71.55% 14.58% -56.98%
+ Complexity 4036 80 -3956
=============================================
Files 1578 1532 -46
Lines 80249 78452 -1797
Branches 11914 11730 -184
=============================================
- Hits 57426 11441 -45985
- Misses 18955 66172 +47217
+ Partials 3868 839 -3029
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mayankshriv
reviewed
Oct 29, 2021
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
override_distinct_count_function_for_table_column
branch
3 times, most recently
from
a2edf4c to
a780267
Compare
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
override_distinct_count_function_for_table_column
branch
7 times, most recently
from
22658d2 to
f0cc2a7
Compare
xiangfu0
force-pushed
the
override_distinct_count_function_for_table_column
branch
from
f0cc2a7 to
fb1363e
Compare
Jackie-Jiang
approved these changes
Nov 1, 2021
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
override_distinct_count_function_for_table_column
branch
from
fb1363e to
9850489
Compare
Jackie-Jiang
reviewed
Nov 1, 2021
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
override_distinct_count_function_for_table_column
branch
from
9850489 to
e25e7e3
Compare
xiangfu0
deleted the
override_distinct_count_function_for_table_column
branch
kriti-sc
pushed a commit
to kriti-sc/incubator-pinot
that referenced
this pull request
Dec 12, 2021
…he#7664) * Allow override distinctCount to segmentPartitionedDistinctCount * check both rt and offline table field configs * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pinot added this SegmentPartitionedDistinctCount function (#5786) long back to allow users to pre-partition distinct key at segment level then speed up distinct count query latency.
This PR introduces the function override automatically once user also specified the column is segment partitioned in FieldConfig prop with:
isSegmentPartitioned=true.Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation