Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance BloomFilter rule to include IN predicate(#7444) #7624

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

GSharayu
Copy link
Contributor

Support in the execution engine was added for bloom filter (#7005) based pruning using IN predicate. The index recommendation rule isn't yet updated to support IN predicate. The current implementation of BloomFilterRule ignores IN predicate, this issue will track removal of that limitation

Issue #7444

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2021

Codecov Report

Merging #7624 (7a74d1e) into master (b2bac68) will increase coverage by 39.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #7624       +/-   ##
=============================================
+ Coverage     32.25%   71.57%   +39.31%     
- Complexity        0     3938     +3938     
=============================================
  Files          1510     1562       +52     
  Lines         74992    79371     +4379     
  Branches      10947    11749      +802     
=============================================
+ Hits          24190    56806    +32616     
+ Misses        48725    18737    -29988     
- Partials       2077     3828     +1751     
Flag Coverage Δ
integration1 29.13% <0.00%> (-1.47%) ⬇️
integration2 27.84% <0.00%> (-1.20%) ⬇️
unittests1 68.58% <ø> (?)
unittests2 14.65% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...roller/recommender/rules/impl/BloomFilterRule.java 100.00% <100.00%> (+100.00%) ⬆️
...data/manager/realtime/SegmentCommitterFactory.java 64.70% <0.00%> (-29.42%) ⬇️
.../RealtimeToOfflineSegmentsTaskExecutorFactory.java 75.00% <0.00%> (-25.00%) ⬇️
...ller/helix/core/minion/TaskTypeMetricsUpdater.java 80.00% <0.00%> (-20.00%) ⬇️
...rawindex/ConvertToRawIndexTaskExecutorFactory.java 80.00% <0.00%> (-20.00%) ⬇️
...ks/mergerollup/MergeRollupTaskExecutorFactory.java 83.33% <0.00%> (-16.67%) ⬇️
...n/minion/tasks/purge/PurgeTaskExecutorFactory.java 60.00% <0.00%> (-15.00%) ⬇️
...h/SegmentGenerationAndPushTaskExecutorFactory.java 60.00% <0.00%> (-15.00%) ⬇️
...er/api/resources/LLCSegmentCompletionHandlers.java 53.46% <0.00%> (-8.92%) ⬇️
...ore/startree/executor/StarTreeGroupByExecutor.java 77.77% <0.00%> (-8.89%) ⬇️
... and 1110 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2bac68...7a74d1e. Read the comment docs.

@siddharthteotia siddharthteotia merged commit d42e415 into apache:master Oct 25, 2021
kriti-sc pushed a commit to kriti-sc/incubator-pinot that referenced this pull request Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants