Refactor query rewriter to interfaces and implementations #7576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
force-pushed
the
calcite-parser-optimizer
branch
2 times, most recently
from
6b31182 to
8c91a2a
Compare
Codecov Report
@@ Coverage Diff @@
## master #7576 +/- ##
============================================
- Coverage 71.61% 64.23% -7.38%
+ Complexity 3884 3804 -80
============================================
Files 1552 1550 -2
Lines 79012 78705 -307
Branches 11705 11668 -37
============================================
- Hits 56585 50559 -6026
- Misses 18618 24549 +5931
+ Partials 3809 3597 -212
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pinot-common/src/main/java/org/apache/pinot/sql/parsers/visitor/QueryVisitor.java
Outdated
Show resolved
Hide resolved
|
|
||
|
|
||
| public interface QueryVisitor { | ||
| void visit(PinotQuery pinotQuery); |
There was a problem hiding this comment.
Let's add some javadoc for the class and method?
For the rewrite, should we return a PinotQuery or always rewrite in-place? For now in-place is enough, not sure about the future rewriters
There was a problem hiding this comment.
Good point, since we are not following visitor model, then I can change the return type to PinotQuery, it's up to each implementation to decide if it's in-place or create new.
pinot-common/src/main/java/org/apache/pinot/sql/parsers/visitor/QueryVisitorFactory.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/sql/parsers/visitor/QueryVisitorFactory.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/sql/parsers/visitor/QueryVisitorFactory.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
calcite-parser-optimizer
branch
7 times, most recently
from
55df822 to
f8ce84c
Compare
Jackie-Jiang
approved these changes
Oct 18, 2021
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/sql/parsers/rewriter/QueryRewriterFactory.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/sql/parsers/rewriter/QueryRewriterFactory.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
calcite-parser-optimizer
branch
7 times, most recently
from
b6bc8d5 to
6368eec
Compare
xiangfu0
force-pushed
the
calcite-parser-optimizer
branch
from
6368eec to
a008154
Compare
This was referenced Nov 1, 2021
kriti-sc
pushed a commit
to kriti-sc/incubator-pinot
that referenced
this pull request
Dec 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
queryVisitorsClassNamesto allow override the default query rewriter class names.Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation