Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the controller getTableInstance() call to return the list of live brokers of a table. #7556

Merged
merged 11 commits into from
Oct 29, 2021
Merged

Let the controller getTableInstance() call to return the list of live brokers of a table. #7556

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e2e3aeb
Let getTableInstance() call to return the list of live brokers.
chenboat Oct 11, 2021
79a96cf
Fix lint errors.
chenboat Oct 11, 2021
53f4aac
Fix lint errors.
chenboat Oct 11, 2021
6ac7f45
Fix unit tests
chenboat Oct 11, 2021
ed67337
Revise based on comments.
chenboat Oct 12, 2021
4e6fdaa
Fix based on comments.
chenboat Oct 13, 2021
52c9daf
Add a new controller end point.
chenboat Oct 13, 2021
6831431
Fix linters.
chenboat Oct 13, 2021
04788f5
Revise based on comments
chenboat Oct 26, 2021
4e871fb
Revise based on comments
chenboat Oct 26, 2021
f13b213
Revised based on comments.
chenboat Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint errors.
  • Loading branch information
@chenboat
chenboat committed Oct 11, 2021
commit 79a96cf1d1cbd0e13d2078aa8b868bd065cb5ed6
3 changes: 2 additions & 1 deletion ...t-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ExternalViewReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ private Map<String, List<String>> getTableToBrokersMapFromExternalView(boolean t
while (resourceEntries.hasNext()) {
Entry<String, JsonNode> resourceEntry = resourceEntries.next();
String resourceName = resourceEntry.getKey();
String tableName = tableWithType ? resourceName: resourceName.replace(OFFLINE_SUFFIX, "").replace(REALTIME_SUFFIX, "");
String tableName =
tableWithType ? resourceName : resourceName.replace(OFFLINE_SUFFIX, "").replace(REALTIME_SUFFIX, "");
Set<String> brokerUrls = brokerUrlsMap.computeIfAbsent(tableName, k -> new HashSet<>());
JsonNode resource = resourceEntry.getValue();
Iterator<Entry<String, JsonNode>> brokerEntries = resource.fields();
Expand Down