Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JsonToPinotSchema consistent with AvroSchemaToPinotSchema #7366

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

Jackie-Jiang
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang commented Aug 25, 2021

Related to #7337

Make JsonToPinotSchema tool consistent with AvroSchemaToPinotSchema, and use -timeColumnName as the option name for DateTimeField.
Remove the deprecated TimeField from the AvroSchemaToPinotSchema.

@Jackie-Jiang Jackie-Jiang requested a review from yupeng9 August 25, 2021 18:09
@Jackie-Jiang Jackie-Jiang changed the title Minor fix to JsonToPinotSchema tool Make JsonToPinotSchema consistent with AvroSchemaToPinotSchema Aug 25, 2021
Copy link
Contributor

@yupeng9 yupeng9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021

Codecov Report

Merging #7366 (589a13a) into master (93f2efb) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head 589a13a differs from pull request most recent head c60c422. Consider uploading reports for the commit c60c422 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7366      +/-   ##
============================================
- Coverage     71.70%   71.69%   -0.01%     
+ Complexity     3390     3303      -87     
============================================
  Files          1515     1515              
  Lines         74983    74979       -4     
  Branches      10906    10904       -2     
============================================
- Hits          53767    53759       -8     
- Misses        17584    17589       +5     
+ Partials       3632     3631       -1     
Flag Coverage Δ
integration1 30.61% <0.00%> (+<0.01%) ⬆️
integration2 29.16% <0.00%> (+0.03%) ⬆️
unittests1 69.47% <50.00%> (-0.03%) ⬇️
unittests2 14.46% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/apache/pinot/spi/utils/JsonUtils.java 66.51% <33.33%> (ø)
...pache/pinot/plugin/inputformat/avro/AvroUtils.java 68.38% <100.00%> (-0.91%) ⬇️
...l/segment/index/readers/OnHeapFloatDictionary.java 90.00% <0.00%> (-5.00%) ⬇️
.../pinot/core/query/scheduler/PriorityScheduler.java 80.82% <0.00%> (-2.74%) ⬇️
...nMaxValueBasedSelectionOrderByCombineOperator.java 68.65% <0.00%> (-2.24%) ⬇️
.../aggregation/function/ModeAggregationFunction.java 86.52% <0.00%> (-1.62%) ⬇️
.../helix/core/realtime/SegmentCompletionManager.java 72.00% <0.00%> (-1.02%) ⬇️
...manager/realtime/LLRealtimeSegmentDataManager.java 72.62% <0.00%> (-0.42%) ⬇️
.../startree/v2/builder/OffHeapSingleTreeBuilder.java 87.42% <0.00%> (ø)
...ache/pinot/common/metadata/ZKMetadataProvider.java 81.20% <0.00%> (+0.75%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93f2efb...c60c422. Read the comment docs.

@Jackie-Jiang Jackie-Jiang merged commit 004c8af into apache:master Aug 25, 2021
@Jackie-Jiang Jackie-Jiang deleted the json_to_pinot_schema branch August 25, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants