Integrate enhanced SegmentProcessorFramework into MergeRollupTaskExecutor #7180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7180 +/- ##
============================================
+ Coverage 73.51% 73.56% +0.04%
Complexity 92 92
============================================
Files 1506 1506
Lines 73832 73807 -25
Branches 10655 10650 -5
============================================
+ Hits 54281 54293 +12
+ Misses 16011 15976 -35
+ Partials 3540 3538 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Jackie-Jiang
force-pushed
the
merge_rollup_executor
branch
from
5ebd40b to
abd83f6
Compare
snleee
reviewed
Jul 20, 2021
| assertEquals(segmentConfig.getMaxNumRecordsPerSegment(), SegmentConfig.DEFAULT_MAX_NUM_RECORDS_PER_SEGMENT); | ||
| assertNull(segmentConfig.getSegmentNamePrefix()); | ||
| } | ||
| } |
...src/main/java/org/apache/pinot/plugin/minion/tasks/merge_rollup/MergeRollupTaskExecutor.java
Show resolved
Hide resolved
...-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MergeTaskUtils.java
Show resolved
Hide resolved
...ion-builtin-tasks/src/test/java/org/apache/pinot/plugin/minion/tasks/MergeTaskUtilsTest.java
Show resolved
Hide resolved
snleee
approved these changes
Jul 21, 2021
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentConfig.java
Show resolved
Hide resolved
...-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MergeTaskUtils.java
Show resolved
Hide resolved
|
LGTM, thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wire the enhanced
SegmentProcessorFrameworkinto the merge/rollup task executor with the following support:Extract the common logic in
RealtimeToOfflineSegmentsTaskExecutorandMergeRollupTaskExecutor